diff options
| author |   Heiner Kallweit <hkallweit1@gmail.com> | 2020-03-20 17:51:38 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2020-03-23 21:09:47 -0700 |
| commit | 5eee3bb7103f4a66e4b90c2817f5e72509a2a607 (patch) | |
| tree | 1b1be649227f2a3cd15e40d7c60a9262c1d18a93 /drivers/net/phy/phy.c | |
| parent | Merge branch 'net-phy-xpcs-Improvements-for-next' (diff) | |
| download | linux-dev-5eee3bb7103f4a66e4b90c2817f5e72509a2a607.tar.xz linux-dev-5eee3bb7103f4a66e4b90c2817f5e72509a2a607.zip | |
net: phy: add and use phy_check_downshift
So far PHY drivers have to check whether a downshift occurred to be
able to notify the user. To make life of drivers authors a little bit
easier move the downshift notification to phylib. phy_check_downshift()
compares the highest mutually advertised speed with the actual value
of phydev->speed (typically read by the PHY driver from a
vendor-specific register) to detect a downshift.
v2:
- Add downshift hint to phy_print_status
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/phy/phy.c')
| -rw-r--r-- | drivers/net/phy/phy.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index d71212a418f3..72c69a9c8a98 100644 --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -96,9 +96,10 @@ void phy_print_status(struct phy_device *phydev) { if (phydev->link) { netdev_info(phydev->attached_dev, - "Link is Up - %s/%s - flow control %s\n", + "Link is Up - %s/%s %s- flow control %s\n", phy_speed_to_str(phydev->speed), phy_duplex_to_str(phydev->duplex), + phydev->downshifted_rate ? "(downshifted) " : "", phy_pause_str(phydev)); } else { netdev_info(phydev->attached_dev, "Link is Down\n"); @@ -507,6 +508,7 @@ static int phy_check_link_status(struct phy_device *phydev) return err; if (phydev->link && phydev->state != PHY_RUNNING) { + phy_check_downshift(phydev); phydev->state = PHY_RUNNING; phy_link_up(phydev); } else if (!phydev->link && phydev->state != PHY_NOLINK) { |