diff options
| author |   Russell King <rmk+kernel@armlinux.org.uk> | 2020-07-21 12:03:45 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2020-07-21 15:46:50 -0700 |
| commit | 1ceb7ee7a6e7a8195fd1fbc3c7d554305bc26607 (patch) | |
| tree | b383ebe7e1b2328e01e65991f2baaea4183a0e2b /drivers/net/phy/phylink.c | |
| parent | Merge branch 'enetc-Add-adaptive-interrupt-coalescing' (diff) | |
| download | linux-dev-1ceb7ee7a6e7a8195fd1fbc3c7d554305bc26607.tar.xz linux-dev-1ceb7ee7a6e7a8195fd1fbc3c7d554305bc26607.zip | |
net: phylink: update ethtool reporting for fixed-link modes
Comparing the ethtool output from phylink and non-phylink fixed-link
setups shows that we have some differences:
- The "auto-negotiation" fields are different; phylink reports these
as "No", non-phylink reports these as "Yes" for the supported and
advertising masks.
- The link partner advertisement is set to the link speed with non-
phylink, but phylink leaves this unset, causing all link partner
fields to be omitted.
The phylink ethtool output also disagrees with the software emulated
PHY dump via the MII registers.
Update the phylink fixed-link parsing code so that we better reflect
the behaviour of the non-phylink code that this facility replaces, and
bring the ethtool interface more into line with the report from via the
MII interface.
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/phy/phylink.c')
| -rw-r--r-- | drivers/net/phy/phylink.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c index dae6c8b51d7f..0fd5a11966aa 100644 --- a/drivers/net/phy/phylink.c +++ b/drivers/net/phy/phylink.c @@ -241,8 +241,10 @@ static int phylink_parse_fixedlink(struct phylink *pl, phylink_set(pl->supported, MII); phylink_set(pl->supported, Pause); phylink_set(pl->supported, Asym_Pause); + phylink_set(pl->supported, Autoneg); if (s) { __set_bit(s->bit, pl->supported); + __set_bit(s->bit, pl->link_config.lp_advertising); } else { phylink_warn(pl, "fixed link %s duplex %dMbps not recognised\n", pl->link_config.duplex == DUPLEX_FULL ? "full" : "half", |