path: root/drivers/net/phy/phylink.c
diff options
authorRussell King <rmk+kernel@armlinux.org.uk>2019-12-11 10:56:50 +0000
committerDavid S. Miller <davem@davemloft.net>2019-12-11 11:53:41 -0800
commit7adb5b2126bc013f0964ddaefad6ad1b132e86c3 (patch)
tree01866d11adf6fd9d8ece8dcddd06c08cfc674c6c /drivers/net/phy/phylink.c
parentnet: phylink: delay MAC configuration for copper SFP modules (diff)
net: phylink: make Broadcom BCM84881 based SFPs work
The Broadcom BCM84881 does not appear to send the SGMII control word when operating in SGMII mode, which causes network adapters to fail to link with the PHY, or decide to operate at fixed 1G speed, even if the PHY negotiated 100M. Work around this by detecting the Broadcom BCM84881 and switch to phy mode rather than inband mode. Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/phy/phylink.c')
1 files changed, 16 insertions, 2 deletions
diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
index 01f958508f80..47614f975344 100644
--- a/drivers/net/phy/phylink.c
+++ b/drivers/net/phy/phylink.c
@@ -1837,10 +1837,20 @@ static void phylink_sfp_link_up(void *upstream)
+/* The Broadcom BCM84881 in the Methode DM7052 is unable to provide a SGMII
+ * or 802.3z control word, so inband will not work.
+ */
+static bool phylink_phy_no_inband(struct phy_device *phy)
+ return phy->is_c45 &&
+ (phy->c45_ids.device_ids[1] & 0xfffffff0) == 0xae025150;
static int phylink_sfp_connect_phy(void *upstream, struct phy_device *phy)
struct phylink *pl = upstream;
phy_interface_t interface;
+ u8 mode;
int ret;
@@ -1852,9 +1862,13 @@ static int phylink_sfp_connect_phy(void *upstream, struct phy_device *phy)
+ if (phylink_phy_no_inband(phy))
+ mode = MLO_AN_PHY;
+ else
+ mode = MLO_AN_INBAND;
/* Do the initial configuration */
- ret = phylink_sfp_config(pl, MLO_AN_INBAND, phy->supported,
- phy->advertising);
+ ret = phylink_sfp_config(pl, mode, phy->supported, phy->advertising);
if (ret < 0)
return ret;