diff options
| author |   Heiner Kallweit <hkallweit1@gmail.com> | 2021-11-24 08:16:25 +0100 |
|---|---|---|
| committer |   Jakub Kicinski <kuba@kernel.org> | 2021-11-24 18:19:58 -0800 |
| commit | ddb826c2c92d461f290a7bab89e7c28696191875 (patch) | |
| tree | fdd33d30e829ef339d29cfef2f619d1901ed302d /drivers/net/phy/phylink.c | |
| parent | tcp_cubic: fix spurious Hystart ACK train detections for not-cwnd-limited flows (diff) | |
| download | linux-dev-ddb826c2c92d461f290a7bab89e7c28696191875.tar.xz linux-dev-ddb826c2c92d461f290a7bab89e7c28696191875.zip | |
lan743x: fix deadlock in lan743x_phy_link_status_change()
Usage of phy_ethtool_get_link_ksettings() in the link status change
handler isn't needed, and in combination with the referenced change
it results in a deadlock. Simply remove the call and replace it with
direct access to phydev->speed. The duplex argument of
lan743x_phy_update_flowcontrol() isn't used and can be removed.
Fixes: c10a485c3de5 ("phy: phy_ethtool_ksettings_get: Lock the phy for consistency")
Reported-by: Alessandro B Maurici <abmaurici@gmail.com>
Tested-by: Alessandro B Maurici <abmaurici@gmail.com>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/40e27f76-0ba3-dcef-ee32-a78b9df38b0f@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/phy/phylink.c')
0 files changed, 0 insertions, 0 deletions