diff options
| author |   Enguerrand de Ribaucourt <enguerrand.de-ribaucourt@savoirfairelinux.com> | 2022-06-23 15:46:45 +0200 |
|---|---|---|
| committer |   Jakub Kicinski <kuba@kernel.org> | 2022-06-24 16:33:22 -0700 |
| commit | 0e597e2affb90d6ea48df6890d882924acf71e19 (patch) | |
| tree | ca5e0ab189ef26fe7e2b61462b289f8e2ce5dadf /drivers/net/phy | |
| parent | net: dp83822: disable false carrier interrupt (diff) | |
| download | linux-dev-0e597e2affb90d6ea48df6890d882924acf71e19.tar.xz linux-dev-0e597e2affb90d6ea48df6890d882924acf71e19.zip | |
net: dp83822: disable rx error interrupt
Some RX errors, notably when disconnecting the cable, increase the RCSR
register. Once half full (0x7fff), an interrupt flood is generated. I
measured ~3k/s interrupts even after the RX errors transfer was
stopped.
Since we don't read and clear the RCSR register, we should disable this
interrupt.
Fixes: 87461f7a58ab ("net: phy: DP83822 initial driver submission")
Signed-off-by: Enguerrand de Ribaucourt <enguerrand.de-ribaucourt@savoirfairelinux.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/phy')
| -rw-r--r-- | drivers/net/phy/dp83822.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/phy/dp83822.c b/drivers/net/phy/dp83822.c index 95ef507053a6..8549e0e356c9 100644 --- a/drivers/net/phy/dp83822.c +++ b/drivers/net/phy/dp83822.c @@ -229,8 +229,7 @@ static int dp83822_config_intr(struct phy_device *phydev) if (misr_status < 0) return misr_status; - misr_status |= (DP83822_RX_ERR_HF_INT_EN | - DP83822_LINK_STAT_INT_EN | + misr_status |= (DP83822_LINK_STAT_INT_EN | DP83822_ENERGY_DET_INT_EN | DP83822_LINK_QUAL_INT_EN); |