diff options
| author |   Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> | 2013-12-20 22:09:04 +0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2013-12-29 22:35:16 -0500 |
| commit | 33c133cc7598e60976a069344910d63e56cc4401 (patch) | |
| tree | 3289d4be3d0e66a2541b692577aeca6e6af0f3a8 /drivers/net/phy | |
| parent | net: rose: restore old recvmsg behavior (diff) | |
| download | linux-dev-33c133cc7598e60976a069344910d63e56cc4401.tar.xz linux-dev-33c133cc7598e60976a069344910d63e56cc4401.zip | |
phy: IRQ cannot be shared
With the way PHY IRQ handler is implemented (all real handling being pushed to
the workqueue and returning IRQ_HANDLED all the time PHY is active), we cannot
really claim that PHY IRQ can be shared when calling request_irq().
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/phy')
| -rw-r--r-- | drivers/net/phy/phy.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index 36c6994436b7..98434b84f041 100644 --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -565,10 +565,8 @@ int phy_start_interrupts(struct phy_device *phydev) int err = 0; atomic_set(&phydev->irq_disable, 0); - if (request_irq(phydev->irq, phy_interrupt, - IRQF_SHARED, - "phy_interrupt", - phydev) < 0) { + if (request_irq(phydev->irq, phy_interrupt, 0, "phy_interrupt", + phydev) < 0) { pr_warn("%s: Can't get IRQ %d (PHY)\n", phydev->bus->name, phydev->irq); phydev->irq = PHY_POLL; |