diff options
| author |   Ben Hutchings <bhutchings@solarflare.com> | 2009-11-23 16:03:45 +0000 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2009-11-24 10:58:39 -0800 |
| commit | 398468ed1b5c61fe8bcbc8cc1ed323e3c23b58ef (patch) | |
| tree | 2c9f8932143b91d8affe388bd21d98beab7c7488 /drivers/net/sfc/efx.c | |
| parent | sfc: SFT9001: Reset LED configuration correctly after blinking (diff) | |
| download | linux-dev-398468ed1b5c61fe8bcbc8cc1ed323e3c23b58ef.tar.xz linux-dev-398468ed1b5c61fe8bcbc8cc1ed323e3c23b58ef.zip | |
sfc: Use a single blink implementation
Only some PHYs have firmware support for a LED blink mode, so we
currently blink the others in a timer function. Since all PHYs have
simple on and off modes, we don't gain anything by using multiple
blink implementations. Also, since we have a process context there
is no need to use a timer.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/sfc/efx.c')
| -rw-r--r-- | drivers/net/sfc/efx.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/drivers/net/sfc/efx.c b/drivers/net/sfc/efx.c index 0d0243b7ac34..612cd815088f 100644 --- a/drivers/net/sfc/efx.c +++ b/drivers/net/sfc/efx.c @@ -1890,7 +1890,9 @@ int efx_port_dummy_op_int(struct efx_nic *efx) return 0; } void efx_port_dummy_op_void(struct efx_nic *efx) {} -void efx_port_dummy_op_blink(struct efx_nic *efx, bool blink) {} +void efx_port_dummy_op_set_id_led(struct efx_nic *efx, enum efx_led_mode mode) +{ +} static struct efx_mac_operations efx_dummy_mac_operations = { .reconfigure = efx_port_dummy_op_void, @@ -1909,9 +1911,8 @@ static struct efx_phy_operations efx_dummy_phy_operations = { static struct efx_board efx_dummy_board_info = { .init = efx_port_dummy_op_int, .init_leds = efx_port_dummy_op_void, - .set_id_led = efx_port_dummy_op_blink, + .set_id_led = efx_port_dummy_op_set_id_led, .monitor = efx_port_dummy_op_int, - .blink = efx_port_dummy_op_blink, .fini = efx_port_dummy_op_void, }; |