diff options
| author |   Michael Chan <mchan@broadcom.com> | 2005-05-29 14:59:49 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2005-05-29 14:59:49 -0700 |
| commit | 1b62815193f6c20c60958e5347751155833e3d35 (patch) | |
| tree | c775c46e63084d6a63e515a303cebf701a673848 /drivers/net/tg3.c | |
| parent | [TG3]: Add interrupt test (diff) | |
| download | linux-dev-1b62815193f6c20c60958e5347751155833e3d35.tar.xz linux-dev-1b62815193f6c20c60958e5347751155833e3d35.zip | |
[TG3]: Fix bug in tg3_load_firmware_cpu
Add tg3_nvram_lock() and tg3_nvram_unlock() calls around tg3_halt_cpu().
It is possible that the bootcode may be loading code from nvram during
this call and stopping the cpu without getting the lock may cause
uncompleted nvram data to be left in the nvram data register. Subsequent
calls to read/write nvram data will fail.
Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/tg3.c')
| -rw-r--r-- | drivers/net/tg3.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index 82afd26a829f..fc9b5cd957aa 100644 --- a/drivers/net/tg3.c +++ b/drivers/net/tg3.c @@ -4370,7 +4370,12 @@ static int tg3_load_firmware_cpu(struct tg3 *tp, u32 cpu_base, u32 cpu_scratch_b */ tp->tg3_flags |= TG3_FLAG_PCIX_TARGET_HWBUG; + /* It is possible that bootcode is still loading at this point. + * Get the nvram lock first before halting the cpu. + */ + tg3_nvram_lock(tp); err = tg3_halt_cpu(tp, cpu_base); + tg3_nvram_unlock(tp); if (err) goto out; |