diff options
| author |   Florian Fainelli <f.fainelli@gmail.com> | 2018-09-28 16:18:50 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-09-29 11:31:29 -0700 |
| commit | c4ce446e33d7a0e978256ac6fea4c80e59d9de5f (patch) | |
| tree | 0339448adb913db070464114eb725f4409fd1488 /drivers/net/usb/asix_common.c | |
| parent | Merge branch 'ieee802154-for-davem-2018-09-28' of git://git.kernel.org/pub/scm/linux/kernel/git/sschmidt/wpan (diff) | |
| download | linux-dev-c4ce446e33d7a0e978256ac6fea4c80e59d9de5f.tar.xz linux-dev-c4ce446e33d7a0e978256ac6fea4c80e59d9de5f.zip | |
asix: Check for supported Wake-on-LAN modes
The driver currently silently accepts unsupported Wake-on-LAN modes
(other than WAKE_PHY or WAKE_MAGIC) without reporting that to the user,
which is confusing.
Fixes: 2e55cc7210fe ("[PATCH] USB: usbnet (3/9) module for ASIX Ethernet adapters")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/usb/asix_common.c')
| -rw-r--r-- | drivers/net/usb/asix_common.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/net/usb/asix_common.c b/drivers/net/usb/asix_common.c index e95dd12edec4..023b8d0bf175 100644 --- a/drivers/net/usb/asix_common.c +++ b/drivers/net/usb/asix_common.c @@ -607,6 +607,9 @@ int asix_set_wol(struct net_device *net, struct ethtool_wolinfo *wolinfo) struct usbnet *dev = netdev_priv(net); u8 opt = 0; + if (wolinfo->wolopts & ~(WAKE_PHY | WAKE_MAGIC)) + return -EINVAL; + if (wolinfo->wolopts & WAKE_PHY) opt |= AX_MONITOR_LINK; if (wolinfo->wolopts & WAKE_MAGIC) |