diff options
| author |   Vladis Dronov <vdronov@redhat.com> | 2020-01-13 14:00:09 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2020-01-14 10:58:57 -0800 |
| commit | 75718584cb3c64e6269109d4d54f888ac5a5fd15 (patch) | |
| tree | 1c3fd98dd98eb3e6b865d65f77238cbedab4c342 /drivers/net/usb/lan78xx.c | |
| parent | NFC: pn533: fix bulk-message timeout (diff) | |
| download | linux-dev-75718584cb3c64e6269109d4d54f888ac5a5fd15.tar.xz linux-dev-75718584cb3c64e6269109d4d54f888ac5a5fd15.zip | |
ptp: free ptp device pin descriptors properly
There is a bug in ptp_clock_unregister(), where ptp_cleanup_pin_groups()
first frees ptp->pin_{,dev_}attr, but then posix_clock_unregister() needs
them to destroy a related sysfs device.
These functions can not be just swapped, as posix_clock_unregister() frees
ptp which is needed in the ptp_cleanup_pin_groups(). Fix this by calling
ptp_cleanup_pin_groups() in ptp_clock_release(), right before ptp is freed.
This makes this patch fix an UAF bug in a patch which fixes an UAF bug.
Reported-by: Antti Laakso <antti.laakso@intel.com>
Fixes: a33121e5487b ("ptp: fix the race between the release of ptp_clock and cdev")
Link: https://lore.kernel.org/netdev/3d2bd09735dbdaf003585ca376b7c1e5b69a19bd.camel@intel.com/
Signed-off-by: Vladis Dronov <vdronov@redhat.com>
Acked-by: Richard Cochran <richardcochran@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/usb/lan78xx.c')
0 files changed, 0 insertions, 0 deletions