diff options
| author |   Phil Elwell <phil@raspberrypi.org> | 2018-04-10 13:18:25 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-04-11 14:44:45 -0400 |
| commit | 47b998653fea4ef69e3e89574956386f262bccca (patch) | |
| tree | e31eeb252287269fc1f33d030497ddcbd3305f72 /drivers/net/usb | |
| parent | Merge branch 'bnxt_en-Fixes-for-net' (diff) | |
| download | linux-dev-47b998653fea4ef69e3e89574956386f262bccca.tar.xz linux-dev-47b998653fea4ef69e3e89574956386f262bccca.zip | |
lan78xx: Don't reset the interface on open
Commit 92571a1aae40 ("lan78xx: Connect phy early") moves the PHY
initialisation into lan78xx_probe, but lan78xx_open subsequently calls
lan78xx_reset. As well as forcing a second round of link negotiation,
this reset frequently prevents the phy interrupt from being generated
(even though the link is up), rendering the interface unusable.
Fix this issue by removing the lan78xx_reset call from lan78xx_open.
Fixes: 92571a1aae40 ("lan78xx: Connect phy early")
Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/usb')
| -rw-r--r-- | drivers/net/usb/lan78xx.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index bdb696612e11..0867f7275852 100644 --- a/drivers/net/usb/lan78xx.c +++ b/drivers/net/usb/lan78xx.c @@ -2515,10 +2515,6 @@ static int lan78xx_open(struct net_device *net) if (ret < 0) goto out; - ret = lan78xx_reset(dev); - if (ret < 0) - goto done; - phy_start(net->phydev); netif_dbg(dev, ifup, dev->net, "phy initialised successfully"); |