diff options
| author |   Markus Elfring <elfring@users.sourceforge.net> | 2019-08-21 22:16:02 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-08-22 16:22:03 -0700 |
| commit | 5477fccf9abd7342a987d401fa50c0d93ebd09b9 (patch) | |
| tree | 0eae33dad1e739f20ac38cd79b06aebd43d25353 /drivers/net/usb | |
| parent | hamradio: Delete unnecessary checks before the macro call “dev_kfree_skb” (diff) | |
| download | linux-dev-5477fccf9abd7342a987d401fa50c0d93ebd09b9.tar.xz linux-dev-5477fccf9abd7342a987d401fa50c0d93ebd09b9.zip | |
net: usb: Delete unnecessary checks before the macro call “dev_kfree_skb”
The dev_kfree_skb() function performs also input parameter validation.
Thus the test around the shown calls is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/usb')
| -rw-r--r-- | drivers/net/usb/lg-vl600.c | 4 | ||||
| -rw-r--r-- | drivers/net/usb/rtl8150.c | 6 |
2 files changed, 3 insertions, 7 deletions
diff --git a/drivers/net/usb/lg-vl600.c b/drivers/net/usb/lg-vl600.c index 6c2b3e368efe..217a2d8fa47b 100644 --- a/drivers/net/usb/lg-vl600.c +++ b/drivers/net/usb/lg-vl600.c @@ -87,9 +87,7 @@ static void vl600_unbind(struct usbnet *dev, struct usb_interface *intf) { struct vl600_state *s = dev->driver_priv; - if (s->current_rx_buf) - dev_kfree_skb(s->current_rx_buf); - + dev_kfree_skb(s->current_rx_buf); kfree(s); return usbnet_cdc_unbind(dev, intf); diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c index 98f33e270af1..13e51ccf0214 100644 --- a/drivers/net/usb/rtl8150.c +++ b/drivers/net/usb/rtl8150.c @@ -586,8 +586,7 @@ static void free_skb_pool(rtl8150_t *dev) int i; for (i = 0; i < RX_SKB_POOL_SIZE; i++) - if (dev->rx_skb_pool[i]) - dev_kfree_skb(dev->rx_skb_pool[i]); + dev_kfree_skb(dev->rx_skb_pool[i]); } static void rx_fixup(unsigned long data) @@ -946,8 +945,7 @@ static void rtl8150_disconnect(struct usb_interface *intf) unlink_all_urbs(dev); free_all_urbs(dev); free_skb_pool(dev); - if (dev->rx_skb) - dev_kfree_skb(dev->rx_skb); + dev_kfree_skb(dev->rx_skb); kfree(dev->intr_buff); free_netdev(dev->netdev); } |