diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2016-05-04 09:22:01 +0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2016-05-04 16:58:57 -0400 |
| commit | 5a36b68b670ebdf19eaedd4f859810293a3d1dc1 (patch) | |
| tree | ae51cb54e4e31140a1e546a4de36badf39c97ef2 /drivers/net/usb | |
| parent | usbnet/smsc75xx: silence uninitialized variable warning (diff) | |
| download | linux-dev-5a36b68b670ebdf19eaedd4f859810293a3d1dc1.tar.xz linux-dev-5a36b68b670ebdf19eaedd4f859810293a3d1dc1.zip | |
usbnet: smsc95xx: silence an uninitialized variable warning
If the call to fn() fails then "buf" is uninitialized. Just return the
error code in that case.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/usb')
| -rw-r--r-- | drivers/net/usb/smsc95xx.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c index 2edc2bc6d1b9..d9d2806a47b1 100644 --- a/drivers/net/usb/smsc95xx.c +++ b/drivers/net/usb/smsc95xx.c @@ -92,9 +92,11 @@ static int __must_check __smsc95xx_read_reg(struct usbnet *dev, u32 index, ret = fn(dev, USB_VENDOR_REQUEST_READ_REGISTER, USB_DIR_IN | USB_TYPE_VENDOR | USB_RECIP_DEVICE, 0, index, &buf, 4); - if (unlikely(ret < 0)) + if (unlikely(ret < 0)) { netdev_warn(dev->net, "Failed to read reg index 0x%08x: %d\n", index, ret); + return ret; + } le32_to_cpus(&buf); *data = buf; |