diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2019-11-13 21:28:31 +0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-11-13 14:30:16 -0800 |
| commit | a56dcc6b455830776899ce3686735f1172e12243 (patch) | |
| tree | db0f7d98c6120e69e1b9a238655a4c5462429b88 /drivers/net/usb | |
| parent | slip: Fix memory leak in slip_open error path (diff) | |
| download | linux-dev-a56dcc6b455830776899ce3686735f1172e12243.tar.xz linux-dev-a56dcc6b455830776899ce3686735f1172e12243.zip | |
net: cdc_ncm: Signedness bug in cdc_ncm_set_dgram_size()
This code is supposed to test for negative error codes and partial
reads, but because sizeof() is size_t (unsigned) type then negative
error codes are type promoted to high positive values and the condition
doesn't work as expected.
Fixes: 332f989a3b00 ("CDC-NCM: handle incomplete transfer of MTU")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/usb')
| -rw-r--r-- | drivers/net/usb/cdc_ncm.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c index a245597a3902..c2c82e6391b4 100644 --- a/drivers/net/usb/cdc_ncm.c +++ b/drivers/net/usb/cdc_ncm.c @@ -579,7 +579,7 @@ static void cdc_ncm_set_dgram_size(struct usbnet *dev, int new_size) err = usbnet_read_cmd(dev, USB_CDC_GET_MAX_DATAGRAM_SIZE, USB_TYPE_CLASS | USB_DIR_IN | USB_RECIP_INTERFACE, 0, iface_no, &max_datagram_size, sizeof(max_datagram_size)); - if (err < sizeof(max_datagram_size)) { + if (err != sizeof(max_datagram_size)) { dev_dbg(&dev->intf->dev, "GET_MAX_DATAGRAM_SIZE failed\n"); goto out; } |