diff options
| author |   Phil Elwell <phil@raspberrypi.org> | 2018-04-11 12:02:47 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-04-11 10:32:43 -0400 |
| commit | fed56079e76461765f1e21c214bd1b614b7981e8 (patch) | |
| tree | e2f0cc7550fe514b3dca951ae7a03db676396e8f /drivers/net/usb | |
| parent | lan78xx: Correctly indicate invalid OTP (diff) | |
| download | linux-dev-fed56079e76461765f1e21c214bd1b614b7981e8.tar.xz linux-dev-fed56079e76461765f1e21c214bd1b614b7981e8.zip | |
lan78xx: Avoid spurious kevent 4 "error"
lan78xx_defer_event generates an error message whenever the work item
is already scheduled. lan78xx_open defers three events -
EVENT_STAT_UPDATE, EVENT_DEV_OPEN and EVENT_LINK_RESET. Being aware
of the likelihood (or certainty) of an error message, the DEV_OPEN
event is added to the set of pending events directly, relying on
the subsequent deferral of the EVENT_LINK_RESET call to schedule the
work. Take the same precaution with EVENT_STAT_UPDATE to avoid a
totally unnecessary error message.
Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/usb')
| -rw-r--r-- | drivers/net/usb/lan78xx.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index 145bb7cbf5b2..bdb696612e11 100644 --- a/drivers/net/usb/lan78xx.c +++ b/drivers/net/usb/lan78xx.c @@ -2503,7 +2503,7 @@ static void lan78xx_init_stats(struct lan78xx_net *dev) dev->stats.rollover_max.eee_tx_lpi_transitions = 0xFFFFFFFF; dev->stats.rollover_max.eee_tx_lpi_time = 0xFFFFFFFF; - lan78xx_defer_kevent(dev, EVENT_STAT_UPDATE); + set_bit(EVENT_STAT_UPDATE, &dev->flags); } static int lan78xx_open(struct net_device *net) |