diff options
| author |   Michael S. Tsirkin <mst@redhat.com> | 2014-10-15 10:22:30 +1030 |
|---|---|---|
| committer |   Rusty Russell <rusty@rustcorp.com.au> | 2014-10-15 10:25:02 +1030 |
| commit | 4baf1e33d0842c9673fef4af207d4b74da8d0126 (patch) | |
| tree | 3279682df4375f86a880c0027a8de2a660eb3d31 /drivers/net/virtio_net.c | |
| parent | virtio: add API to enable VQs early (diff) | |
| download | linux-dev-4baf1e33d0842c9673fef4af207d4b74da8d0126.tar.xz linux-dev-4baf1e33d0842c9673fef4af207d4b74da8d0126.zip | |
virtio_net: enable VQs early
virtio spec requires drivers to set DRIVER_OK before using VQs.
This is set automatically after probe returns, virtio net violated this
rule by using receive VQs within probe.
To fix, call virtio_device_ready before using VQs.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Diffstat (limited to 'drivers/net/virtio_net.c')
| -rw-r--r-- | drivers/net/virtio_net.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index ef04d2394282..aba7b93286b3 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -1792,6 +1792,8 @@ static int virtnet_probe(struct virtio_device *vdev) goto free_vqs; } + virtio_device_ready(vdev); + /* Last of all, set up some receive buffers. */ for (i = 0; i < vi->curr_queue_pairs; i++) { try_fill_recv(&vi->rq[i], GFP_KERNEL); |