diff options
| author |   Jason Wang <jasowang@redhat.com> | 2021-09-17 16:34:06 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2021-09-19 12:10:26 +0100 |
| commit | afd92d82c9d715fb97565408755acad81573591a (patch) | |
| tree | 4bce793d193f1e55ec265c6a8379adb65b1ad0a1 /drivers/net/virtio_net.c | |
| parent | xen-netback: correct success/error reporting for the SKB-with-fraglist case (diff) | |
| download | linux-dev-afd92d82c9d715fb97565408755acad81573591a.tar.xz linux-dev-afd92d82c9d715fb97565408755acad81573591a.zip | |
virtio-net: fix pages leaking when building skb in big mode
We try to use build_skb() if we had sufficient tailroom. But we forget
to release the unused pages chained via private in big mode which will
leak pages. Fixing this by release the pages after building the skb in
big mode.
Cc: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Fixes: fb32856b16ad ("virtio-net: page_to_skb() use build_skb when there's sufficient tailroom")
Signed-off-by: Jason Wang <jasowang@redhat.com>
Reviewed-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/virtio_net.c')
| -rw-r--r-- | drivers/net/virtio_net.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 271d38c1d9f8..79bd2585ec6b 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -423,6 +423,10 @@ static struct sk_buff *page_to_skb(struct virtnet_info *vi, skb_reserve(skb, p - buf); skb_put(skb, len); + + page = (struct page *)page->private; + if (page) + give_pages(rq, page); goto ok; } |