diff options
| author |   Jia-Ju Bai <baijiaju1990@gmail.com> | 2020-05-30 10:41:50 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2020-06-01 11:52:59 -0700 |
| commit | 3e1c6846b9e108740ef8a37be80314053f5dd52a (patch) | |
| tree | 4c57ea55d26523b47401b18674b7ea1adf01fdf5 /drivers/net/vmxnet3 | |
| parent | flow_dissector: work around stack frame size warning (diff) | |
| download | linux-dev-3e1c6846b9e108740ef8a37be80314053f5dd52a.tar.xz linux-dev-3e1c6846b9e108740ef8a37be80314053f5dd52a.zip | |
net: vmxnet3: fix possible buffer overflow caused by bad DMA value in vmxnet3_get_rss()
The value adapter->rss_conf is stored in DMA memory, and it is assigned
to rssConf, so rssConf->indTableSize can be modified at anytime by
malicious hardware. Because rssConf->indTableSize is assigned to n,
buffer overflow may occur when the code "rssConf->indTable[n]" is
executed.
To fix this possible bug, n is checked after being used.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/vmxnet3')
| -rw-r--r-- | drivers/net/vmxnet3/vmxnet3_ethtool.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/net/vmxnet3/vmxnet3_ethtool.c b/drivers/net/vmxnet3/vmxnet3_ethtool.c index bfdda0f34b97..6acaafe169de 100644 --- a/drivers/net/vmxnet3/vmxnet3_ethtool.c +++ b/drivers/net/vmxnet3/vmxnet3_ethtool.c @@ -954,6 +954,8 @@ vmxnet3_get_rss(struct net_device *netdev, u32 *p, u8 *key, u8 *hfunc) *hfunc = ETH_RSS_HASH_TOP; if (!p) return 0; + if (n > UPT1_RSS_MAX_IND_TABLE_SIZE) + return 0; while (n--) p[n] = rssConf->indTable[n]; return 0; |