diff options
| author |   Zhengchao Shao <shaozhengchao@huawei.com> | 2022-11-03 17:05:37 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2022-11-07 09:31:26 +0000 |
| commit | 531705a765493655472c993627106e19f7e5a6d2 (patch) | |
| tree | cb77c29aaafad44d556a7edbeb19bfe08d8881b8 /drivers/net/wan/lapbether.c | |
| parent | net: fman: Unregister ethernet device on removal (diff) | |
| download | linux-dev-531705a765493655472c993627106e19f7e5a6d2.tar.xz linux-dev-531705a765493655472c993627106e19f7e5a6d2.zip | |
net: lapbether: fix issue of dev reference count leakage in lapbeth_device_event()
When following tests are performed, it will cause dev reference counting
leakage.
a)ip link add bond2 type bond mode balance-rr
b)ip link set bond2 up
c)ifenslave -f bond2 rose1
d)ip link del bond2
When new bond device is created, the default type of the bond device is
ether. And the bond device is up, lapbeth_device_event() receives the
message and creates a new lapbeth device. In this case, the reference
count value of dev is hold once. But after "ifenslave -f bond2 rose1"
command is executed, the type of the bond device is changed to rose. When
the bond device is unregistered, lapbeth_device_event() will not put the
dev reference count.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/wan/lapbether.c')
| -rw-r--r-- | drivers/net/wan/lapbether.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/wan/lapbether.c b/drivers/net/wan/lapbether.c index 960f1393595c..cb360dca3250 100644 --- a/drivers/net/wan/lapbether.c +++ b/drivers/net/wan/lapbether.c @@ -446,7 +446,7 @@ static int lapbeth_device_event(struct notifier_block *this, if (dev_net(dev) != &init_net) return NOTIFY_DONE; - if (!dev_is_ethdev(dev)) + if (!dev_is_ethdev(dev) && !lapbeth_get_x25_dev(dev)) return NOTIFY_DONE; switch (event) { |