diff options
| author |   Peng Li <lipeng321@huawei.com> | 2021-06-16 15:23:30 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2021-06-16 00:52:33 -0700 |
| commit | 2076b3e61a323e38256be44289aa32ae12ecf79a (patch) | |
| tree | d97f5b862da256cca715bb9e66a7c7f6d53a4ff7 /drivers/net/wan | |
| parent | net: cosa: fix the code style issue about "foo* bar" (diff) | |
| download | linux-dev-2076b3e61a323e38256be44289aa32ae12ecf79a.tar.xz linux-dev-2076b3e61a323e38256be44289aa32ae12ecf79a.zip | |
net: cosa: replace comparison to NULL with "!chan->rx_skb"
According to the chackpatch.pl, comparison to NULL could
be written "!chan->rx_skb".
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/wan')
| -rw-r--r-- | drivers/net/wan/cosa.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/net/wan/cosa.c b/drivers/net/wan/cosa.c index c051c6120e30..7b57233aeec9 100644 --- a/drivers/net/wan/cosa.c +++ b/drivers/net/wan/cosa.c @@ -719,7 +719,7 @@ static char *cosa_net_setup_rx(struct channel_data *chan, int size) */ kfree_skb(chan->rx_skb); chan->rx_skb = dev_alloc_skb(size); - if (chan->rx_skb == NULL) { + if (!chan->rx_skb) { pr_notice("%s: Memory squeeze, dropping packet\n", chan->name); chan->netdev->stats.rx_dropped++; return NULL; @@ -783,7 +783,7 @@ static ssize_t cosa_read(struct file *file, return -ERESTARTSYS; chan->rxdata = kmalloc(COSA_MTU, GFP_DMA|GFP_KERNEL); - if (chan->rxdata == NULL) { + if (!chan->rxdata) { mutex_unlock(&chan->rlock); return -ENOMEM; } @@ -861,7 +861,7 @@ static ssize_t cosa_write(struct file *file, /* Allocate the buffer */ kbuf = kmalloc(count, GFP_KERNEL|GFP_DMA); - if (kbuf == NULL) { + if (!kbuf) { up(&chan->wsem); return -ENOMEM; } |