diff options
| author |   Salva Peiró <speiro@ai2.upv.es> | 2013-10-16 12:46:50 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2013-10-18 16:04:25 -0400 |
| commit | 2b13d06c9584b4eb773f1e80bbaedab9a1c344e1 (patch) | |
| tree | 401bfe11c8f592d0a6927ff0f36b2deda8ef80f6 /drivers/net/wan | |
| parent | Merge branch 'bridge_pvid' (diff) | |
| download | linux-dev-2b13d06c9584b4eb773f1e80bbaedab9a1c344e1.tar.xz linux-dev-2b13d06c9584b4eb773f1e80bbaedab9a1c344e1.zip | |
wanxl: fix info leak in ioctl
The wanxl_ioctl() code fails to initialize the two padding bytes of
struct sync_serial_settings after the ->loopback member. Add an explicit
memset(0) before filling the structure to avoid the info leak.
Signed-off-by: Salva Peiró <speiro@ai2.upv.es>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/wan')
| -rw-r--r-- | drivers/net/wan/wanxl.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/wan/wanxl.c b/drivers/net/wan/wanxl.c index 6a24a5a70cc7..4c0a69779b89 100644 --- a/drivers/net/wan/wanxl.c +++ b/drivers/net/wan/wanxl.c @@ -355,6 +355,7 @@ static int wanxl_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) ifr->ifr_settings.size = size; /* data size wanted */ return -ENOBUFS; } + memset(&line, 0, sizeof(line)); line.clock_type = get_status(port)->clocking; line.clock_rate = 0; line.loopback = 0; |