aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/wan
diff options
context:
space:
mode:
authorPeng Li <lipeng321@huawei.com>2021-06-17 22:03:18 +0800
committerDavid S. Miller <davem@davemloft.net>2021-06-17 12:08:46 -0700
commitee58a3c7c6bbabb0bf3685a8b437b5d4be33890c (patch)
tree63d432eab3b8094ed9983e79129cc5245e164247 /drivers/net/wan
parentnet: hdlc_ppp: move out assignment in if condition (diff)
downloadlinux-dev-ee58a3c7c6bbabb0bf3685a8b437b5d4be33890c.tar.xz
linux-dev-ee58a3c7c6bbabb0bf3685a8b437b5d4be33890c.zip
net: hdlc_ppp: remove unnecessary out of memory message
This patch removes unnecessary out of memory message, to fix the following checkpatch.pl warning: "WARNING: Possible unnecessary 'out of memory' message" Signed-off-by: Peng Li <lipeng321@huawei.com> Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/wan')
-rw-r--r--drivers/net/wan/hdlc_ppp.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/net/wan/hdlc_ppp.c b/drivers/net/wan/hdlc_ppp.c
index fb5102c1afc6..aec9cc4d5b48 100644
--- a/drivers/net/wan/hdlc_ppp.c
+++ b/drivers/net/wan/hdlc_ppp.c
@@ -219,10 +219,9 @@ static void ppp_tx_cp(struct net_device *dev, u16 pid, u8 code,
skb = dev_alloc_skb(sizeof(struct hdlc_header) +
sizeof(struct cp_header) + magic_len + len);
- if (!skb) {
- netdev_warn(dev, "out of memory in ppp_tx_cp()\n");
+ if (!skb)
return;
- }
+
skb_reserve(skb, sizeof(struct hdlc_header));
cp = skb_put(skb, sizeof(struct cp_header));