diff options
| author |   Ahmad Fatoum <a.fatoum@pengutronix.de> | 2018-08-21 17:35:48 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-08-25 17:30:02 -0700 |
| commit | ab5f11055fdf8dfc3ddbd89e8e3cc550de41d1d3 (patch) | |
| tree | b0609681db92929a9e0578351375fc4214ba4597 /drivers/net/wimax | |
| parent | mlxsw: spectrum_switchdev: Do not leak RIFs when removing bridge (diff) | |
| download | linux-dev-ab5f11055fdf8dfc3ddbd89e8e3cc550de41d1d3.tar.xz linux-dev-ab5f11055fdf8dfc3ddbd89e8e3cc550de41d1d3.zip | |
net: macb: Fix regression breaking non-MDIO fixed-link PHYs
commit 739de9a1563a ("net: macb: Reorganize macb_mii bringup") broke
initializing macb on the EVB-KSZ9477 eval board.
There, of_mdiobus_register was called even for the fixed-link representing
the RGMII-link to the switch with the result that the driver attempts to
enumerate PHYs on a non-existent MDIO bus:
libphy: MACB_mii_bus: probed
mdio_bus f0028000.ethernet-ffffffff: fixed-link has invalid PHY address
mdio_bus f0028000.ethernet-ffffffff: scan phy fixed-link at address 0
[snip]
mdio_bus f0028000.ethernet-ffffffff: scan phy fixed-link at address 31
The "MDIO" bus registration succeeds regardless, having claimed the reset GPIO,
and calling of_phy_register_fixed_link later on fails because it tries
to claim the same GPIO:
macb f0028000.ethernet: broken fixed-link specification
Fix this by registering the fixed-link before calling mdiobus_register.
Fixes: 739de9a1563a ("net: macb: Reorganize macb_mii bringup")
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/wimax')
0 files changed, 0 insertions, 0 deletions