diff options
| author |   Rakesh Pillai <pillair@codeaurora.org> | 2020-12-12 00:30:10 +0530 |
|---|---|---|
| committer |   Kalle Valo <kvalo@codeaurora.org> | 2020-12-17 08:49:07 +0200 |
| commit | 31561e8557cd1eeba5806ac9ce820f8323b2201b (patch) | |
| tree | 3aaded346603e6618d4f84e25fde982e14a24ae0 /drivers/net/wireless/ath/ath10k/snoc.c | |
| parent | net: x25: Remove unimplemented X.25-over-LLC code stubs (diff) | |
| download | linux-dev-31561e8557cd1eeba5806ac9ce820f8323b2201b.tar.xz linux-dev-31561e8557cd1eeba5806ac9ce820f8323b2201b.zip | |
ath10k: Fix error handling in case of CE pipe init failure
Currently if the copy engine pipe init fails for snoc based
chipsets, the rri is not freed.
Fix this error handling for copy engine pipe init
failure.
Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1
Fixes: 4945af5b264f ("ath10k: enable SRRI/DRRI support on ddr for WCN3990")
Signed-off-by: Rakesh Pillai <pillair@codeaurora.org>
Reviewed-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/1607713210-18320-1-git-send-email-pillair@codeaurora.org
Diffstat (limited to 'drivers/net/wireless/ath/ath10k/snoc.c')
| -rw-r--r-- | drivers/net/wireless/ath/ath10k/snoc.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/net/wireless/ath/ath10k/snoc.c b/drivers/net/wireless/ath/ath10k/snoc.c index bf9a8cb713dc..1c3307e3b108 100644 --- a/drivers/net/wireless/ath/ath10k/snoc.c +++ b/drivers/net/wireless/ath/ath10k/snoc.c @@ -1045,12 +1045,13 @@ static int ath10k_snoc_hif_power_up(struct ath10k *ar, ret = ath10k_snoc_init_pipes(ar); if (ret) { ath10k_err(ar, "failed to initialize CE: %d\n", ret); - goto err_wlan_enable; + goto err_free_rri; } return 0; -err_wlan_enable: +err_free_rri: + ath10k_ce_free_rri(ar); ath10k_snoc_wlan_disable(ar); return ret; |