diff options
| author |   Colin Ian King <colin.king@canonical.com> | 2019-10-04 17:02:27 +0100 |
|---|---|---|
| committer |   Kalle Valo <kvalo@codeaurora.org> | 2019-10-11 11:45:53 +0300 |
| commit | a69d3bdd4d40c8f780c94b5e1983adb1cd389b59 (patch) | |
| tree | ec054f4001547aec4f0d52dc0bd3a762b2c535b1 /drivers/net/wireless/ath/ath10k/snoc.c | |
| parent | ath10k: enable transmit data ack RSSI for QCA9884 (diff) | |
| download | linux-dev-a69d3bdd4d40c8f780c94b5e1983adb1cd389b59.tar.xz linux-dev-a69d3bdd4d40c8f780c94b5e1983adb1cd389b59.zip | |
ath10k: fix null dereference on pointer crash_data
Currently when pointer crash_data is null the present null check
will also check that crash_data->ramdump_buf is null and will cause
a null pointer dereference on crash_data. Fix this by using the ||
operator instead of &&.
Fixes: 3f14b73c3843 ("ath10k: Enable MSA region dump support for WCN3990")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Diffstat (limited to 'drivers/net/wireless/ath/ath10k/snoc.c')
| -rw-r--r-- | drivers/net/wireless/ath/ath10k/snoc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/wireless/ath/ath10k/snoc.c b/drivers/net/wireless/ath/ath10k/snoc.c index cd22c8654aa9..16177497bba7 100644 --- a/drivers/net/wireless/ath/ath10k/snoc.c +++ b/drivers/net/wireless/ath/ath10k/snoc.c @@ -1400,7 +1400,7 @@ static void ath10k_msa_dump_memory(struct ath10k *ar, size_t buf_len; u8 *buf; - if (!crash_data && !crash_data->ramdump_buf) + if (!crash_data || !crash_data->ramdump_buf) return; mem_layout = ath10k_coredump_get_mem_layout(ar); |