diff options
| author |   Luca Coelho <luciano.coelho@intel.com> | 2021-12-19 11:01:28 +0200 |
|---|---|---|
| committer |   Kalle Valo <kvalo@kernel.org> | 2021-12-20 20:41:30 +0200 |
| commit | 97c0979d0d729cded6eae0d7b22d06a2eeeca3a4 (patch) | |
| tree | de795297e28e237ab27fcc770492f1c72f67f237 /drivers/net/wireless/intel/iwlwifi/mvm/ops.c | |
| parent | iwlwifi: mvm: add dbg_time_point to debugfs (diff) | |
| download | linux-dev-97c0979d0d729cded6eae0d7b22d06a2eeeca3a4.tar.xz linux-dev-97c0979d0d729cded6eae0d7b22d06a2eeeca3a4.zip | |
iwlwifi: mvm: fix imbalanced locking in iwl_mvm_start_get_nvm()
If iwl_transt_start_hw() failed, we were returning without calling
wiphy_unlock() and rtnl_unlock(), causing a locking imbalance:
drivers/net/wireless/intel/iwlwifi/mvm/ops.c:686:12: warning: context imbalance in 'iwl_mvm_start_get_nvm' - wrong count at exit
Fix that by adding the unlock calls.
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20211219090128.42417-2-luca@coelho.fi
Diffstat (limited to 'drivers/net/wireless/intel/iwlwifi/mvm/ops.c')
| -rw-r--r-- | drivers/net/wireless/intel/iwlwifi/mvm/ops.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/ops.c b/drivers/net/wireless/intel/iwlwifi/mvm/ops.c index 9bd869b8a974..3941baa3eda3 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/ops.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/ops.c @@ -718,6 +718,8 @@ get_nvm_from_fw: ret = iwl_trans_start_hw(mvm->trans); if (ret) { mutex_unlock(&mvm->mutex); + wiphy_unlock(mvm->hw->wiphy); + rtnl_unlock(); return ret; } |