diff options
| author |   Eric Dumazet <eric.dumazet@gmail.com> | 2012-03-24 00:29:46 -0400 |
|---|---|---|
| committer |   John W. Linville <linville@tuxdriver.com> | 2012-05-03 10:52:30 -0400 |
| commit | ed90542b0ce5415050c6fbfca324bccaafa69f2f (patch) | |
| tree | bc8426e780dd399259af2f8ba6e775b613714dc8 /drivers/net/wireless/iwlwifi/iwl-trans.h | |
| parent | Revert "ath9k_hw: Fix incorrect spur_freq_sd for AR9003" (diff) | |
| download | linux-dev-ed90542b0ce5415050c6fbfca324bccaafa69f2f.tar.xz linux-dev-ed90542b0ce5415050c6fbfca324bccaafa69f2f.zip | |
iwlwifi: fix skb truesize underestimation
By default, iwlwifi uses order-1 pages (8 KB) to store incoming frames,
but doesnt say so in skb->truesize.
This makes very possible to exhaust kernel memory since these skb evade
normal socket memory accounting.
As struct ieee80211_hdr is going to be pulled before calling IP stack,
there is no need to use dev_alloc_skb() to reserve NET_SKB_PAD bytes.
alloc_skb() is ok in this driver, allowing more tailroom.
Pull beginning of frame in skb header, in the hope we can reuse order-1
pages in the driver immediately for small frames and reduce their
truesize to the minimum (linear skbs)
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Wey-Yi Guy <wey-yi.w.guy@intel.com>
Cc: "John W. Linville" <linville@tuxdriver.com>
Cc: Neal Cardwell <ncardwell@google.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/wireless/iwlwifi/iwl-trans.h')
| -rw-r--r-- | drivers/net/wireless/iwlwifi/iwl-trans.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/wireless/iwlwifi/iwl-trans.h b/drivers/net/wireless/iwlwifi/iwl-trans.h index 0c81cbaa8088..fdf97886a5e4 100644 --- a/drivers/net/wireless/iwlwifi/iwl-trans.h +++ b/drivers/net/wireless/iwlwifi/iwl-trans.h @@ -260,6 +260,7 @@ static inline void iwl_free_resp(struct iwl_host_cmd *cmd) struct iwl_rx_cmd_buffer { struct page *_page; + unsigned int truesize; }; static inline void *rxb_addr(struct iwl_rx_cmd_buffer *r) |