diff options
| author |   Johannes Berg <johannes.berg@intel.com> | 2012-08-21 18:57:10 +0200 |
|---|---|---|
| committer |   John W. Linville <linville@tuxdriver.com> | 2012-08-21 15:01:44 -0400 |
| commit | 94543a8d4fb302817014981489f15cb3b92ec3c2 (patch) | |
| tree | 651bad8e64bfaab497786cd6521f9db1bd3988d0 /drivers/net/wireless/iwlwifi/pcie/rx.c | |
| parent | drivers/net/wireless/ipw2x00/ipw2100.c: introduce missing initialization (diff) | |
| download | linux-dev-94543a8d4fb302817014981489f15cb3b92ec3c2.tar.xz linux-dev-94543a8d4fb302817014981489f15cb3b92ec3c2.zip | |
iwlwifi: fix flow handler debug code
iwl_dbgfs_fh_reg_read() can cause crashes and/or
BUG_ON in slub because the ifdefs are wrong, the
code in iwl_dump_fh() should use DEBUGFS, not
DEBUG to protect the buffer writing code.
Also, while at it, clean up the arguments to the
function, some code and make it generally safer.
Cc: stable@vger.kernel.org
Reported-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/wireless/iwlwifi/pcie/rx.c')
| -rw-r--r-- | drivers/net/wireless/iwlwifi/pcie/rx.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/wireless/iwlwifi/pcie/rx.c b/drivers/net/wireless/iwlwifi/pcie/rx.c index 39a6ca1f009c..d1a61ba6247a 100644 --- a/drivers/net/wireless/iwlwifi/pcie/rx.c +++ b/drivers/net/wireless/iwlwifi/pcie/rx.c @@ -555,7 +555,7 @@ static void iwl_irq_handle_error(struct iwl_trans *trans) } iwl_dump_csr(trans); - iwl_dump_fh(trans, NULL, false); + iwl_dump_fh(trans, NULL); iwl_op_mode_nic_error(trans->op_mode); } |