diff options
| author |   Holger Schurig <hs4233@mail.mn-solutions.de> | 2008-03-19 15:24:21 +0100 |
|---|---|---|
| committer |   John W. Linville <linville@tuxdriver.com> | 2008-03-27 14:28:30 -0400 |
| commit | dd1f635fe0f14d8c03181f9f1f743b127694fc14 (patch) | |
| tree | b098f82d5f57e98558a2828ac5bac280b2763378 /drivers/net/wireless/libertas/if_cs.c | |
| parent | [IPSEC]: Fix BEET output (diff) | |
| download | linux-dev-dd1f635fe0f14d8c03181f9f1f743b127694fc14.tar.xz linux-dev-dd1f635fe0f14d8c03181f9f1f743b127694fc14.zip | |
libertas: fix spinlock recursion bug
This fixes a bug detected by CONFIG_DEBUG_SPINLOCK:
if_cs_get_int_status() is only called from lbs_thread(), via
priv->hw_get_int_status. However, lbs_thread() has already taken the
priv->driver_lock. So it's a fault to take the same lock again here.
Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>
Acked-by: Dan Williams <dcbw@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/wireless/libertas/if_cs.c')
| -rw-r--r-- | drivers/net/wireless/libertas/if_cs.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/net/wireless/libertas/if_cs.c b/drivers/net/wireless/libertas/if_cs.c index 5a9cadb97503..038c66a98f15 100644 --- a/drivers/net/wireless/libertas/if_cs.c +++ b/drivers/net/wireless/libertas/if_cs.c @@ -677,9 +677,7 @@ sbi_get_int_status_exit: /* Card has a command result for us */ if (*ireg & IF_CS_C_S_CMD_UPLD_RDY) { - spin_lock(&priv->driver_lock); ret = if_cs_receive_cmdres(priv, priv->upld_buf, &priv->upld_len); - spin_unlock(&priv->driver_lock); if (ret < 0) lbs_pr_err("could not receive cmd from card\n"); } |