aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/wireless/marvell/mwifiex/pcie.c
diff options
context:
space:
mode:
authorBrian Norris <briannorris@chromium.org>2017-04-14 14:51:18 -0700
committerKalle Valo <kvalo@codeaurora.org>2017-04-20 10:21:52 +0300
commit9ae3fbd109d9d89c442a3412e41fc532a9829ea8 (patch)
treea532673eb0e16ca58cf3c28d7ff07177457bb476 /drivers/net/wireless/marvell/mwifiex/pcie.c
parentmwifiex: pcie: fix cmd_buf use-after-free in remove/reset (diff)
downloadlinux-dev-9ae3fbd109d9d89c442a3412e41fc532a9829ea8.tar.xz
linux-dev-9ae3fbd109d9d89c442a3412e41fc532a9829ea8.zip
mwifiex: reset timeout flag when resetting device
If we reset because of a command timeout, we should reset this flag. Otherwise, we might erroneously think the next command after reset is timing out, and trigger another reset. The above behavior effectively neuters the automatic card_reset() behavior, as it means we will never recover from a command timeout properly (and in fact, we might enter an infinite loop: timeout -> reset -> (fake) timeout -> reset -> ... This fixes a bug introduced with introduction of PCIe function level reset support, but it was carried into the SDIO driver when it was converted to use the same codepaths. And this is currently mostly a problem only in the SDIO driver, because it's the only one with automatic card_reset() support (e.g., on command timeout). But it will be a problem for PCIe too, as I'm working on supporting automatic card_reset() for PCIe. Fixes: c742e623e941 ("mwifiex: sdio card reset enhancement") Fixes: 4c5dae59d2e9 ("mwifiex: add PCIe function level reset support") Signed-off-by: Brian Norris <briannorris@chromium.org> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Diffstat (limited to 'drivers/net/wireless/marvell/mwifiex/pcie.c')
0 files changed, 0 insertions, 0 deletions