diff options
| author |   Navid Emamdoost <navid.emamdoost@gmail.com> | 2019-10-04 15:08:52 -0500 |
|---|---|---|
| committer |   Kalle Valo <kvalo@codeaurora.org> | 2019-10-09 11:24:52 +0300 |
| commit | db8fd2cde93227e566a412cf53173ffa227998bc (patch) | |
| tree | 5ca5ecc7bfd2693bf9944992367c2358591e9c76 /drivers/net/wireless/marvell/mwifiex/pcie.c | |
| parent | rsi: drop bogus device-id checks from probe (diff) | |
| download | linux-dev-db8fd2cde93227e566a412cf53173ffa227998bc.tar.xz linux-dev-db8fd2cde93227e566a412cf53173ffa227998bc.zip | |
mwifiex: pcie: Fix memory leak in mwifiex_pcie_alloc_cmdrsp_buf
In mwifiex_pcie_alloc_cmdrsp_buf, a new skb is allocated which should be
released if mwifiex_map_pci_memory() fails. The release is added.
Fixes: fc3314609047 ("mwifiex: use pci_alloc/free_consistent APIs for PCIe")
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Acked-by: Ganapathi Bhat <gbhat@marvell.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Diffstat (limited to 'drivers/net/wireless/marvell/mwifiex/pcie.c')
| -rw-r--r-- | drivers/net/wireless/marvell/mwifiex/pcie.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/wireless/marvell/mwifiex/pcie.c b/drivers/net/wireless/marvell/mwifiex/pcie.c index eff06d59e9df..1578eaa071bd 100644 --- a/drivers/net/wireless/marvell/mwifiex/pcie.c +++ b/drivers/net/wireless/marvell/mwifiex/pcie.c @@ -1029,8 +1029,10 @@ static int mwifiex_pcie_alloc_cmdrsp_buf(struct mwifiex_adapter *adapter) } skb_put(skb, MWIFIEX_UPLD_SIZE); if (mwifiex_map_pci_memory(adapter, skb, MWIFIEX_UPLD_SIZE, - PCI_DMA_FROMDEVICE)) + PCI_DMA_FROMDEVICE)) { + kfree_skb(skb); return -1; + } card->cmdrsp_buf = skb; |