diff options
| author |   Igor Mitsyanko <igor.mitsyanko.os@quantenna.com> | 2018-01-22 15:46:33 +0300 |
|---|---|---|
| committer |   Kalle Valo <kvalo@codeaurora.org> | 2018-01-24 18:00:55 +0200 |
| commit | 237d29f6ce46a37908e5c1e0b29520ae8ee7c8f0 (patch) | |
| tree | 5d0c2bda3a94a47ec2a2dab33a1a1299328cb176 /drivers/net/wireless/quantenna | |
| parent | qtnfmac: do not use mutexes in timer context (diff) | |
| download | linux-dev-237d29f6ce46a37908e5c1e0b29520ae8ee7c8f0.tar.xz linux-dev-237d29f6ce46a37908e5c1e0b29520ae8ee7c8f0.zip | |
qtnfmac: do not use bus mutex for events processing
Events processing requires locking of bus mutex, which is also used by
cfg80211 layer before calling several of cfg80211 callbacks. Since all
cfg80211 callbacks in qtnfmac driver also lock bus mutex, this
potentially may lead to a deadlock.
Do not use bus lock for event processing. Use RTNL lock instead to
serialize events and commands processing threads.
Signed-off-by: Igor Mitsyanko <igor.mitsyanko.os@quantenna.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Diffstat (limited to 'drivers/net/wireless/quantenna')
| -rw-r--r-- | drivers/net/wireless/quantenna/qtnfmac/event.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/wireless/quantenna/qtnfmac/event.c b/drivers/net/wireless/quantenna/qtnfmac/event.c index 8a3d2b1194e4..bcd415f96412 100644 --- a/drivers/net/wireless/quantenna/qtnfmac/event.c +++ b/drivers/net/wireless/quantenna/qtnfmac/event.c @@ -541,9 +541,9 @@ static int qtnf_event_process_skb(struct qtnf_bus *bus, if (unlikely(!mac)) return -ENXIO; - qtnf_bus_lock(bus); + rtnl_lock(); res = qtnf_event_parse(mac, skb); - qtnf_bus_unlock(bus); + rtnl_unlock(); return res; } |