diff options
| author |   Aditya Srivastava <yashsri421@gmail.com> | 2021-01-10 17:45:23 +0530 |
|---|---|---|
| committer |   Kalle Valo <kvalo@codeaurora.org> | 2021-01-25 16:21:07 +0200 |
| commit | 64338f0dfd6a3be20453789c6a4b2c7246e2aef8 (patch) | |
| tree | 2a83a1fa7482fee5ea657b7a719e53b64d38501c /drivers/net/wireless/realtek/rtlwifi/rtl8188ee/dm.c | |
| parent | rtlwifi: rtl8192c-common: fix bool comparison in expressions (diff) | |
| download | linux-dev-64338f0dfd6a3be20453789c6a4b2c7246e2aef8.tar.xz linux-dev-64338f0dfd6a3be20453789c6a4b2c7246e2aef8.zip | |
rtlwifi: rtl8188ee: fix bool comparison in expressions
There are certain conditional expressions in rtl8188ee, where a boolean
variable is compared with true/false, in forms such as (foo == true) or
(false != bar), which does not comply with checkpatch.pl (CHECK:
BOOL_COMPARISON), according to which boolean variables should be
themselves used in the condition, rather than comparing with true/false
E.g., in drivers/net/wireless/realtek/rtlwifi/rtl8188ee/dm.c,
"if (mac->act_scanning == true)" can be replaced with
"if (mac->act_scanning)"
Replace all such expressions with the bool variables appropriately
Signed-off-by: Aditya Srivastava <yashsri421@gmail.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20210110121525.2407-4-yashsri421@gmail.com
Diffstat (limited to 'drivers/net/wireless/realtek/rtlwifi/rtl8188ee/dm.c')
| -rw-r--r-- | drivers/net/wireless/realtek/rtlwifi/rtl8188ee/dm.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/dm.c b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/dm.c index d10c14c694da..6f61d6a10627 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/dm.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/dm.c @@ -474,11 +474,11 @@ static void rtl88e_dm_dig(struct ieee80211_hw *hw) u8 dm_dig_max, dm_dig_min; u8 current_igi = dm_dig->cur_igvalue; - if (rtlpriv->dm.dm_initialgain_enable == false) + if (!rtlpriv->dm.dm_initialgain_enable) return; - if (dm_dig->dig_enable_flag == false) + if (!dm_dig->dig_enable_flag) return; - if (mac->act_scanning == true) + if (mac->act_scanning) return; if (mac->link_state >= MAC80211_LINKED) @@ -1637,7 +1637,7 @@ static void rtl88e_dm_fast_ant_training(struct ieee80211_hw *hw) } } - if (bpkt_filter_match == false) { + if (!bpkt_filter_match) { rtl_set_bbreg(hw, DM_REG_TXAGC_A_1_MCS32_11N, BIT(16), 0); rtl_set_bbreg(hw, DM_REG_IGI_A_11N, BIT(7), 0); |