diff options
| author |   Matthias Kaehlcke <mka@chromium.org> | 2018-02-08 16:57:12 -0800 |
|---|---|---|
| committer |   Kalle Valo <kvalo@codeaurora.org> | 2018-02-27 18:17:30 +0200 |
| commit | fb239c1209bb0f0b4830cc72507cc2f2d63fadbd (patch) | |
| tree | bc0508efd54ff90d8304558849fa51c89720e5e6 /drivers/net/wireless/realtek/rtlwifi/rtl8192cu | |
| parent | wireless: zd1211rw: remove redundant assignment of pointer 'q' (diff) | |
| download | linux-dev-fb239c1209bb0f0b4830cc72507cc2f2d63fadbd.tar.xz linux-dev-fb239c1209bb0f0b4830cc72507cc2f2d63fadbd.zip | |
rtlwifi: rtl8192cu: Remove variable self-assignment in rf.c
In _rtl92c_get_txpower_writeval_by_regulatory() the variable writeVal
is assigned to itself in an if ... else statement, apparently only to
document that the branch condition is handled and that a previously read
value should be returned unmodified. The self-assignment causes clang to
raise the following warning:
drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c:304:13:
error: explicitly assigning value of variable of type 'u32'
(aka 'unsigned int') to itself [-Werror,-Wself-assign]
writeVal = writeVal;
Delete the branch with the self-assignment.
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Diffstat (limited to 'drivers/net/wireless/realtek/rtlwifi/rtl8192cu')
| -rw-r--r-- | drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c index 9cff6bc4049c..cf551785eb08 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c @@ -299,9 +299,6 @@ static void _rtl92c_get_txpower_writeval_by_regulatory(struct ieee80211_hw *hw, writeVal = 0x00000000; if (rtlpriv->dm.dynamic_txhighpower_lvl == TXHIGHPWRLEVEL_BT1) writeVal = writeVal - 0x06060606; - else if (rtlpriv->dm.dynamic_txhighpower_lvl == - TXHIGHPWRLEVEL_BT2) - writeVal = writeVal; *(p_outwriteval + rf) = writeVal; } } |