aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/wireless/realtek/rtlwifi/rtl8723com/fw_common.c
diff options
context:
space:
mode:
authorPing-Ke Shih <pkshih@realtek.com>2017-12-29 16:31:09 +0800
committerKalle Valo <kvalo@codeaurora.org>2018-01-08 19:07:45 +0200
commit981a2b6e055bce9a9f780fb074ffdf9a9bab0d47 (patch)
tree9b0c71a0b51c0d9a3e8ea9ac686c797f1589aadb /drivers/net/wireless/realtek/rtlwifi/rtl8723com/fw_common.c
parentrtlwifi: Remove unnecessary parentheses (diff)
downloadlinux-dev-981a2b6e055bce9a9f780fb074ffdf9a9bab0d47.tar.xz
linux-dev-981a2b6e055bce9a9f780fb074ffdf9a9bab0d47.zip
rtlwifi: rtl8723: Add error handling to no existing firmware
Without firmware, driver wastes time to download and wait for MCU bootup, and then kernel core dump finally. If request_firmware fails, the value max_fw_size=0 is set, so we check the value before downloading firmware. Signed-off-by: Ping-Ke Shih <pkshih@realtek.com> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Diffstat (limited to 'drivers/net/wireless/realtek/rtlwifi/rtl8723com/fw_common.c')
-rw-r--r--drivers/net/wireless/realtek/rtlwifi/rtl8723com/fw_common.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723com/fw_common.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723com/fw_common.c
index efa7e1262461..0d1ebc861720 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8723com/fw_common.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723com/fw_common.c
@@ -196,7 +196,7 @@ int rtl8723_download_fw(struct ieee80211_hw *hw,
enum version_8723e version = rtlhal->version;
int max_page;
- if (!rtlhal->pfirmware)
+ if (rtlpriv->max_fw_size == 0 || !rtlhal->pfirmware)
return 1;
pfwheader = (struct rtlwifi_firmware_header *)rtlhal->pfirmware;