diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2020-05-13 12:39:51 +0300 |
|---|---|---|
| committer |   Kalle Valo <kvalo@codeaurora.org> | 2020-05-18 15:15:25 +0300 |
| commit | beb12813bc75d4a23de43b85ad1c7cb28d27631e (patch) | |
| tree | 955a00396d27062ddd4c9fb7d3441ada9495842e /drivers/net/wireless/realtek/rtw88/coex.c | |
| parent | Merge tag 'mt76-for-kvalo-2020-05-14' of https://github.com/nbd168/wireless (diff) | |
| download | linux-dev-beb12813bc75d4a23de43b85ad1c7cb28d27631e.tar.xz linux-dev-beb12813bc75d4a23de43b85ad1c7cb28d27631e.zip | |
rtlwifi: Fix a double free in _rtl_usb_tx_urb_setup()
Seven years ago we tried to fix a leak but actually introduced a double
free instead. It was an understandable mistake because the code was a
bit confusing and the free was done in the wrong place. The "skb"
pointer is freed in both _rtl_usb_tx_urb_setup() and _rtl_usb_transmit().
The free belongs _rtl_usb_transmit() instead of _rtl_usb_tx_urb_setup()
and I've cleaned the code up a bit to hopefully make it more clear.
Fixes: 36ef0b473fbf ("rtlwifi: usb: add missing freeing of skbuff")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200513093951.GD347693@mwanda
Diffstat (limited to 'drivers/net/wireless/realtek/rtw88/coex.c')
0 files changed, 0 insertions, 0 deletions