diff options
| author |   Brian Norris <briannorris@chromium.org> | 2019-11-06 13:30:55 -0800 |
|---|---|---|
| committer |   Kalle Valo <kvalo@codeaurora.org> | 2019-11-08 10:27:03 +0200 |
| commit | 21c60a28af58d7c376502c26fbb0064b39c32917 (patch) | |
| tree | 492416b003c52b6e15323ffbe7881f82a7ca8d82 /drivers/net/wireless | |
| parent | rtw88: fix potential NULL pointer access for firmware (diff) | |
| download | linux-dev-21c60a28af58d7c376502c26fbb0064b39c32917.tar.xz linux-dev-21c60a28af58d7c376502c26fbb0064b39c32917.zip | |
rtw88: signal completion even on firmware-request failure
Otherwise, the waiters (e.g., "modprobe rtwpci") will block forever.
Fixes: f530c1961af2 ("rtw88: fix potential NULL pointer access for firmware")
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Yan-Hsuan Chuang <yhchuang@realtek.com>
Signed-off-by: Brian Norris <briannorris@chromium.org>
Acked-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Diffstat (limited to 'drivers/net/wireless')
| -rw-r--r-- | drivers/net/wireless/realtek/rtw88/main.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/wireless/realtek/rtw88/main.c b/drivers/net/wireless/realtek/rtw88/main.c index de82d08ea29e..ae61415e1665 100644 --- a/drivers/net/wireless/realtek/rtw88/main.c +++ b/drivers/net/wireless/realtek/rtw88/main.c @@ -1026,6 +1026,7 @@ static void rtw_load_firmware_cb(const struct firmware *firmware, void *context) if (!firmware || !firmware->data) { rtw_err(rtwdev, "failed to request firmware\n"); + complete_all(&fw->completion); return; } |