diff options
| author |   Johannes Berg <johannes.berg@intel.com> | 2018-08-15 18:17:03 +0200 |
|---|---|---|
| committer | Johannes Berg <johannes.berg@intel.com> | 2018-08-15 18:17:03 +0200 |
| commit | 484004339d4514fde425f6e8a9f6a6cc979bb0c3 (patch) | |
| tree | 6deb3b1e8572645c50e95c925f70d57eaeeabf76 /drivers/net/wireless | |
| parent | mac80211: Run TXQ teardown code before de-registering interfaces (diff) | |
| download | linux-dev-484004339d4514fde425f6e8a9f6a6cc979bb0c3.tar.xz linux-dev-484004339d4514fde425f6e8a9f6a6cc979bb0c3.zip | |
mac80211_hwsim: require at least one channel
Syzbot continues to try to create mac80211_hwsim radios, and
manages to pass parameters that are later checked with WARN_ON
in cfg80211 - catch another one in hwsim directly.
Reported-by: syzbot+2a12f11c306afe871c1f@syzkaller.appspotmail.com
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Diffstat (limited to 'drivers/net/wireless')
| -rw-r--r-- | drivers/net/wireless/mac80211_hwsim.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/net/wireless/mac80211_hwsim.c b/drivers/net/wireless/mac80211_hwsim.c index 18e819d964f1..fe1b0108f06d 100644 --- a/drivers/net/wireless/mac80211_hwsim.c +++ b/drivers/net/wireless/mac80211_hwsim.c @@ -3194,6 +3194,11 @@ static int hwsim_new_radio_nl(struct sk_buff *msg, struct genl_info *info) if (info->attrs[HWSIM_ATTR_CHANNELS]) param.channels = nla_get_u32(info->attrs[HWSIM_ATTR_CHANNELS]); + if (param.channels < 1) { + GENL_SET_ERR_MSG(info, "must have at least one channel"); + return -EINVAL; + } + if (param.channels > CFG80211_MAX_NUM_DIFFERENT_CHANNELS) { GENL_SET_ERR_MSG(info, "too many channels specified"); return -EINVAL; |