diff options
| author |   Hans de Goede <hdegoede@redhat.com> | 2018-11-23 10:11:48 +0100 |
|---|---|---|
| committer |   Kalle Valo <kvalo@codeaurora.org> | 2018-11-29 17:32:25 +0200 |
| commit | 554da3868eb1d7174710c18b4ddd6ff01f6d612c (patch) | |
| tree | d36251ebfcb2ae4c0026ac069af233c02849c427 /drivers/net/wireless | |
| parent | brcmfmac: support STA info struct v7 (diff) | |
| download | linux-dev-554da3868eb1d7174710c18b4ddd6ff01f6d612c.tar.xz linux-dev-554da3868eb1d7174710c18b4ddd6ff01f6d612c.zip | |
brcmfmac: Call brcmf_dmi_probe before brcmf_of_probe
ARM systems with UEFI may have both devicetree (of) and DMI data in this
case we end up setting brcmf_mp_device.board_type twice.
In this case we should prefer the devicetree data, because:
1) The devicerree data is more reliable
2) Some ARM systems (e.g. the Raspberry Pi 3 models) support both UEFI and
classic uboot booting, the devicetree data is always there, so using it
makes sure we ask for the same nvram file independent of how we booted.
This commit moves the brcmf_dmi_probe call to before the brcmf_of_probe
call, so that the latter can override the value of the first if both are
set.
Fixes: bd1e82bb420a ("brcmfmac: Set board_type from DMI on x86 based ...")
Cc: Peter Robinson <pbrobinson@gmail.com>
Tested-and-reported-by: Peter Robinson <pbrobinson@gmail.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Diffstat (limited to 'drivers/net/wireless')
| -rw-r--r-- | drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c index e738112ed87c..1f1e95a15a17 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c @@ -449,8 +449,8 @@ struct brcmf_mp_device *brcmf_get_module_param(struct device *dev, } if (!found) { /* No platform data for this device, try OF and DMI data */ - brcmf_of_probe(dev, bus_type, settings); brcmf_dmi_probe(settings, chip, chiprev); + brcmf_of_probe(dev, bus_type, settings); } return settings; } |