diff options
| author |   Florian Fainelli <f.fainelli@gmail.com> | 2016-07-18 16:24:35 -0700 |
|---|---|---|
| committer |   Kalle Valo <kvalo@codeaurora.org> | 2016-07-19 21:14:20 +0300 |
| commit | 5c5fa1f464ac954982df1d96b9f9a5103d21aedd (patch) | |
| tree | 16cbb3041f805c8b46829f2e548c4761b4883963 /drivers/net/wireless | |
| parent | brcmfmac: Fix glob_skb leak in brcmf_sdiod_recv_chain (diff) | |
| download | linux-dev-5c5fa1f464ac954982df1d96b9f9a5103d21aedd.tar.xz linux-dev-5c5fa1f464ac954982df1d96b9f9a5103d21aedd.zip | |
brcmsmac: Free packet if dma_mapping_error() fails in dma_rxfill
In case dma_mapping_error() returns an error in dma_rxfill, we would be
leaking a packet that we allocated with brcmu_pkt_buf_get_skb().
Reported-by: coverity (CID 1081819)
Fixes: 67d0cf50bd32 ("brcmsmac: Fix WARNING caused by lack of calls to dma_mapping_error()")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Diffstat (limited to 'drivers/net/wireless')
| -rw-r--r-- | drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.c index 796f5f9d5d5a..b7df576bb84d 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.c @@ -1079,8 +1079,10 @@ bool dma_rxfill(struct dma_pub *pub) pa = dma_map_single(di->dmadev, p->data, di->rxbufsize, DMA_FROM_DEVICE); - if (dma_mapping_error(di->dmadev, pa)) + if (dma_mapping_error(di->dmadev, pa)) { + brcmu_pkt_buf_free_skb(p); return false; + } /* save the free packet pointer */ di->rxp[rxout] = p; |