diff options
| author |   M Chetan Kumar <m.chetan.kumar@linux.intel.com> | 2022-01-04 20:32:13 +0530 |
|---|---|---|
| committer |   Jakub Kicinski <kuba@kernel.org> | 2022-01-04 18:15:17 -0800 |
| commit | ffd32ea6b13c97904cae59bdb13a843d52756578 (patch) | |
| tree | a129125ffb7290904da53e37066ce86dc933e54f /drivers/net/wwan | |
| parent | Merge tag 'mac80211-next-for-net-next-2022-01-04' of git://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next (diff) | |
| download | linux-dev-ffd32ea6b13c97904cae59bdb13a843d52756578.tar.xz linux-dev-ffd32ea6b13c97904cae59bdb13a843d52756578.zip | |
Revert "net: wwan: iosm: Keep device at D0 for s2idle case"
Depending on BIOS configuration IOSM driver exchanges
protocol required for putting device into D3L2 or D3L1.2.
ipc_pcie_suspend_s2idle() is implemented to put device to D3L1.2.
This patch forces PCI core know this device should stay at D0.
- pci_save_state()is expensive since it does a lot of slow PCI
config reads.
The reported issue is not observed on x86 platform. The supurios
wake on AMD platform needs to be futher debugged with orignal patch
submitter [1]. Also the impact of adding pci_save_state() needs to be
assessed by testing it on other platforms.
This reverts commit f4dd5174e273("net: wwan: iosm: Keep device
at D0 for s2idle case").
[1] https://lore.kernel.org/all/20211224081914.345292-2-kai.heng.feng@canonical.com/
Signed-off-by: M Chetan Kumar <m.chetan.kumar@linux.intel.com>
Link: https://lore.kernel.org/r/20220104150213.1894-1-m.chetan.kumar@linux.intel.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/wwan')
| -rw-r--r-- | drivers/net/wwan/iosm/iosm_ipc_pcie.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/net/wwan/iosm/iosm_ipc_pcie.c b/drivers/net/wwan/iosm/iosm_ipc_pcie.c index af1d0e837fe9..d73894e2a84e 100644 --- a/drivers/net/wwan/iosm/iosm_ipc_pcie.c +++ b/drivers/net/wwan/iosm/iosm_ipc_pcie.c @@ -340,9 +340,6 @@ static int __maybe_unused ipc_pcie_suspend_s2idle(struct iosm_pcie *ipc_pcie) ipc_imem_pm_s2idle_sleep(ipc_pcie->imem, true); - /* Let PCI core know this device should stay at D0 */ - pci_save_state(ipc_pcie->pci); - return 0; } |