path: root/drivers/net/xen-netback/netback.c
diff options
authorFlorian Fainelli <f.fainelli@gmail.com>2015-05-29 10:29:46 -0700
committerDavid S. Miller <davem@davemloft.net>2015-05-31 21:50:34 -0700
commit24595346d79b6bd98a77d24c493e8490639788fc (patch)
tree54dd40e424ac6e63a508ac960931111b065ade48 /drivers/net/xen-netback/netback.c
parenttcp: fix child sockets to use system default congestion control if not set (diff)
net: dsa: Properly propagate errors from dsa_switch_setup_one
While shuffling some code around, dsa_switch_setup_one() was introduced, and it was modified to return either an error code using ERR_PTR() or a NULL pointer when running out of memory or failing to setup a switch. This is a problem for its caler: dsa_switch_setup() which uses IS_ERR() and expects to find an error code, not a NULL pointer, so we still try to proceed with dsa_switch_setup() and operate on invalid memory addresses. This can be easily reproduced by having e.g: the bcm_sf2 driver built-in, but having no such switch, such that drv->setup will fail. Fix this by using PTR_ERR() consistently which is both more informative and avoids for the caller to use IS_ERR_OR_NULL(). Fixes: df197195a5248 ("net: dsa: split dsa_switch_setup into two functions") Reported-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> Tested-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/xen-netback/netback.c')
0 files changed, 0 insertions, 0 deletions