diff options
| author |   Wei Liu <wei.liu2@citrix.com> | 2014-08-12 11:59:30 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2014-08-13 20:06:43 -0700 |
| commit | 628fa76b09d7b0923c142631fc25b6affbfb868d (patch) | |
| tree | 1c738b4350f79c4f65f1a2441a857b88eb8ccb7b /drivers/net/xen-netback/xenbus.c | |
| parent | xen-netback: fix debugfs write length check (diff) | |
| download | linux-dev-628fa76b09d7b0923c142631fc25b6affbfb868d.tar.xz linux-dev-628fa76b09d7b0923c142631fc25b6affbfb868d.zip | |
xen-netback: fix debugfs entry creation
The original code is bogus. The function gets called in a loop which
leaks entries created in previous rounds.
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Cc: Zoltan Kiss <zoltan.kiss@citrix.com>
Cc: Ian Campbell <ian.campbell@citrix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/xen-netback/xenbus.c')
| -rw-r--r-- | drivers/net/xen-netback/xenbus.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c index 4c9041e60e7d..9c47b897b6d2 100644 --- a/drivers/net/xen-netback/xenbus.c +++ b/drivers/net/xen-netback/xenbus.c @@ -174,10 +174,9 @@ static const struct file_operations xenvif_dbg_io_ring_ops_fops = { .write = xenvif_write_io_ring, }; -static void xenvif_debugfs_addif(struct xenvif_queue *queue) +static void xenvif_debugfs_addif(struct xenvif *vif) { struct dentry *pfile; - struct xenvif *vif = queue->vif; int i; if (IS_ERR_OR_NULL(xen_netback_dbg_root)) @@ -736,10 +735,11 @@ static void connect(struct backend_info *be) be->vif->num_queues = queue_index; goto err; } + } + #ifdef CONFIG_DEBUG_FS - xenvif_debugfs_addif(queue); + xenvif_debugfs_addif(be->vif); #endif /* CONFIG_DEBUG_FS */ - } /* Initialisation completed, tell core driver the number of * active queues. |