diff options
| author |   Yuchung Cheng <ycheng@google.com> | 2017-05-10 17:01:27 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2017-05-11 21:35:20 -0400 |
| commit | b451e5d24ba6687c6f0e7319c727a709a1846c06 (patch) | |
| tree | 6c608e72316408de39225799630de48ee6d0509c /drivers/net/xen-netfront.c | |
| parent | netem: fix skb_orphan_partial() (diff) | |
| download | linux-dev-b451e5d24ba6687c6f0e7319c727a709a1846c06.tar.xz linux-dev-b451e5d24ba6687c6f0e7319c727a709a1846c06.zip | |
tcp: avoid fragmenting peculiar skbs in SACK
This patch fixes a bug in splitting an SKB during SACK
processing. Specifically if an skb contains multiple
packets and is only partially sacked in the higher sequences,
tcp_match_sack_to_skb() splits the skb and marks the second fragment
as SACKed.
The current code further attempts rounding up the first fragment
to MSS boundaries. But it misses a boundary condition when the
rounded-up fragment size (pkt_len) is exactly skb size. Spliting
such an skb is pointless and causses a kernel warning and aborts
the SACK processing. This patch universally checks such over-split
before calling tcp_fragment to prevent these unnecessary warnings.
Fixes: adb92db857ee ("tcp: Make SACK code to split only at mss boundaries")
Signed-off-by: Yuchung Cheng <ycheng@google.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Soheil Hassas Yeganeh <soheil@google.com>
Acked-by: Neal Cardwell <ncardwell@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/xen-netfront.c')
0 files changed, 0 insertions, 0 deletions