diff options
| author |   Jia-Ju Bai <baijiaju1990@163.com> | 2017-12-12 17:26:36 +0800 |
|---|---|---|
| committer |   Johannes Berg <johannes.berg@intel.com> | 2017-12-19 09:14:06 +0100 |
| commit | 162bd5e5fd921785077b5862d8f2ffabe2fe11e5 (patch) | |
| tree | 26cc8e6a69b56fce2c1eae9b634c08c8253216ab /drivers/net | |
| parent | cfg80211: always rewrite generated files from scratch (diff) | |
| download | linux-dev-162bd5e5fd921785077b5862d8f2ffabe2fe11e5.tar.xz linux-dev-162bd5e5fd921785077b5862d8f2ffabe2fe11e5.zip | |
mac80211_hwsim: Fix a possible sleep-in-atomic bug in hwsim_get_radio_nl
The driver may sleep under a spinlock.
The function call path is:
hwsim_get_radio_nl (acquire the spinlock)
nlmsg_new(GFP_KERNEL) --> may sleep
To fix it, GFP_KERNEL is replaced with GFP_ATOMIC.
This bug is found by my static analysis tool(DSAC) and checked by my code review.
Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/wireless/mac80211_hwsim.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/wireless/mac80211_hwsim.c b/drivers/net/wireless/mac80211_hwsim.c index 59b0cedcdf7b..e8189c07b41f 100644 --- a/drivers/net/wireless/mac80211_hwsim.c +++ b/drivers/net/wireless/mac80211_hwsim.c @@ -3216,7 +3216,7 @@ static int hwsim_get_radio_nl(struct sk_buff *msg, struct genl_info *info) if (!net_eq(wiphy_net(data->hw->wiphy), genl_info_net(info))) continue; - skb = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL); + skb = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_ATOMIC); if (!skb) { res = -ENOMEM; goto out_err; |