aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net
diff options
context:
space:
mode:
authorDavid S. Miller <davem@davemloft.net>2018-06-28 22:21:33 +0900
committerDavid S. Miller <davem@davemloft.net>2018-06-28 22:21:33 +0900
commit16c0cd074f2fde76541395c6b269dd3a44d7425b (patch)
treef692ec93f735a81396e68840004926ac8e0d7184 /drivers/net
parentMerge branch 'net-sched-actions-code-style-cleanup-and-fixes' (diff)
parentskbuff: preserve sock reference when scrubbing the skb. (diff)
downloadlinux-dev-16c0cd074f2fde76541395c6b269dd3a44d7425b.tar.xz
linux-dev-16c0cd074f2fde76541395c6b269dd3a44d7425b.zip
Merge branch 'net-preserve-sock-reference-when-scrubbing-the-skb'
Flavio Leitner says: ==================== net: preserve sock reference when scrubbing the skb. The sock reference is lost when scrubbing the packet and that breaks TSQ (TCP Small Queues) and XPS (Transmit Packet Steering) causing performance impacts of about 50% in a single TCP stream when crossing network namespaces. XPS breaks because the queue mapping stored in the socket is not available, so another random queue might be selected when the stack needs to transmit something like a TCP ACK, or TCP Retransmissions. That causes packet re-ordering and/or performance issues. TSQ breaks because it orphans the packet while it is still in the host, so packets are queued contributing to the buffer bloat problem. Preserving the sock reference fixes both issues. The socket is orphaned anyways in the receiving path before any relevant action, but the transmit side needs some extra checking included in the first patch. The first patch will update netfilter to check if the socket netns is local before use it. The second patch removes the skb_orphan() from the skb_scrub_packet() and improve the documentation. ChangeLog: - split into two (Eric) - addressed Paolo's offline feedback to swap the checks in xt_socket.c to preserve original behavior. - improved ip-sysctl.txt (reported by Cong) ==================== Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
0 files changed, 0 insertions, 0 deletions