diff options
| author |   Lars Persson <lars.persson@axis.com> | 2017-12-01 11:12:44 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2017-12-03 09:47:42 -0500 |
| commit | 45ab4b13e46325d00f4acdb365d406e941a15f81 (patch) | |
| tree | 30cdaa2a0c1e70bdeaa6a67428fbfec9456f33e0 /drivers/net | |
| parent | ipvlan: Add the skb->mark as flow4's member to lookup route (diff) | |
| download | linux-dev-45ab4b13e46325d00f4acdb365d406e941a15f81.tar.xz linux-dev-45ab4b13e46325d00f4acdb365d406e941a15f81.zip | |
stmmac: reset last TSO segment size after device open
The mss variable tracks the last max segment size sent to the TSO
engine. We do not update the hardware as long as we receive skb:s with
the same value in gso_size.
During a network device down/up cycle (mapped to stmmac_release() and
stmmac_open() callbacks) we issue a reset to the hardware and it
forgets the setting for mss. However we did not zero out our mss
variable so the next transmission of a gso packet happens with an
undefined hardware setting.
This triggers a hang in the TSO engine and eventuelly the netdev
watchdog will bark.
Fixes: f748be531d70 ("stmmac: support new GMAC4")
Signed-off-by: Lars Persson <larper@axis.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index f63c2ddced3c..d7250539d0bd 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -2588,6 +2588,7 @@ static int stmmac_open(struct net_device *dev) priv->dma_buf_sz = STMMAC_ALIGN(buf_sz); priv->rx_copybreak = STMMAC_RX_COPYBREAK; + priv->mss = 0; ret = alloc_dma_desc_resources(priv); if (ret < 0) { |