diff options
| author |   Oliver Hartkopp <oliver@hartkopp.net> | 2009-09-15 01:31:34 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2009-09-15 01:31:34 -0700 |
| commit | 481a8199142c050b72bff8a1956a49fd0a75bbe0 (patch) | |
| tree | 66bcd9798738a760c9982d62b9a39b57774e8349 /drivers/net | |
| parent | tcp: fix ssthresh u16 leftover (diff) | |
| download | linux-dev-481a8199142c050b72bff8a1956a49fd0a75bbe0.tar.xz linux-dev-481a8199142c050b72bff8a1956a49fd0a75bbe0.zip | |
can: fix NOHZ local_softirq_pending 08 warning
When using nanosleep() in an userspace application we get a ratelimit warning
NOHZ: local_softirq_pending 08
for 10 times.
The echo of CAN frames is done from process context and softirq context only.
Therefore the usage of netif_rx() was wrong (for years).
This patch replaces netif_rx() with netif_rx_ni() which has to be used from
process/softirq context. It also adds a missing comment that can_send() must
no be used from hardirq context.
Signed-off-by: Oliver Hartkopp <oliver@hartkopp.net>
Signed-off-by: Urs Thuermann <urs@isnogud.escape.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/can/vcan.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/can/vcan.c b/drivers/net/can/vcan.c index 6971f6cd37fa..80ac56313981 100644 --- a/drivers/net/can/vcan.c +++ b/drivers/net/can/vcan.c @@ -80,7 +80,7 @@ static void vcan_rx(struct sk_buff *skb, struct net_device *dev) skb->dev = dev; skb->ip_summed = CHECKSUM_UNNECESSARY; - netif_rx(skb); + netif_rx_ni(skb); } static netdev_tx_t vcan_tx(struct sk_buff *skb, struct net_device *dev) |