diff options
| author |   Jason Wang <jasowang@redhat.com> | 2018-05-22 11:44:29 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-05-23 13:36:19 -0400 |
| commit | 5d458a13dd59d04b4d6658a6d5b94d42732b15ae (patch) | |
| tree | 27fb76cef17f55beb1c8c498f63849da396e5663 /drivers/net | |
| parent | virtio-net: correctly redirect linearized packet (diff) | |
| download | linux-dev-5d458a13dd59d04b4d6658a6d5b94d42732b15ae.tar.xz linux-dev-5d458a13dd59d04b4d6658a6d5b94d42732b15ae.zip | |
virtio-net: correctly transmit XDP buff after linearizing
We should not go for the error path after successfully transmitting a
XDP buffer after linearizing. Since the error path may try to pop and
drop next packet and increase the drop counters. Fixing this by simply
drop the refcnt of original page and go for xmit path.
Fixes: 72979a6c3590 ("virtio_net: xdp, add slowpath case for non contiguous buffers")
Cc: John Fastabend <john.fastabend@gmail.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/virtio_net.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index c15d240f643f..6260d6549ee8 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -775,7 +775,7 @@ static struct sk_buff *receive_mergeable(struct net_device *dev, } *xdp_xmit = true; if (unlikely(xdp_page != page)) - goto err_xdp; + put_page(page); rcu_read_unlock(); goto xdp_xmit; case XDP_REDIRECT: |