diff options
| author |   Sabrina Dubroca <sd@queasysnail.net> | 2022-11-02 22:33:15 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2022-11-04 10:43:56 +0000 |
| commit | 80df4706357a5a06bbbc70273bf2611df1ceee04 (patch) | |
| tree | 6acbb17cae9d4a447bca2902524d1dde987b01e1 /drivers/net | |
| parent | macsec: fix secy->n_rx_sc accounting (diff) | |
| download | linux-dev-80df4706357a5a06bbbc70273bf2611df1ceee04.tar.xz linux-dev-80df4706357a5a06bbbc70273bf2611df1ceee04.zip | |
macsec: fix detection of RXSCs when toggling offloading
macsec_is_configured incorrectly uses secy->n_rx_sc to check if some
RXSCs exist. secy->n_rx_sc only counts the number of active RXSCs, but
there can also be inactive SCs as well, which may be stored in the
driver (in case we're disabling offloading), or would have to be
pushed to the device (in case we're trying to enable offloading).
As long as RXSCs active on creation and never turned off, the issue is
not visible.
Fixes: dcb780fb2795 ("net: macsec: add nla support for changing the offloading selection")
Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Reviewed-by: Antoine Tenart <atenart@kernel.org>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/macsec.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/macsec.c b/drivers/net/macsec.c index 1b4d856f4bd7..700a8f96c6c2 100644 --- a/drivers/net/macsec.c +++ b/drivers/net/macsec.c @@ -2571,7 +2571,7 @@ static bool macsec_is_configured(struct macsec_dev *macsec) struct macsec_tx_sc *tx_sc = &secy->tx_sc; int i; - if (secy->n_rx_sc > 0) + if (secy->rx_sc) return true; for (i = 0; i < MACSEC_NUM_AN; i++) |